link options - only allow when fs has urls

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 - CKEditor config edit pages now warn when switching the Config Options setting from JavaScript to JSON if the JavaScript code contains any functions. ([#152](https://github.com/craftcms/ckeditor/issues/152), [#180](https://github.com/craftcms/ckeditor/pull/180))
+- Fixed a bug where the “Link to an asset” option was showing up when there weren’t any available volumes with URLs. ([#179](https://github.com/craftcms/ckeditor/issues/179))
 
 ## 3.8.0 - 2024-02-21
 

src/Field.php

@@ -344,6 +344,8 @@ protected function inputHtml(mixed $value, ElementInterface $element = null): st
                     'imageTextAlternative',
                 ],
             ],
+            'assetSources' => $this->_assetSources(),
+            'assetSelectionCriteria' => $this->_assetSelectionCriteria(),
             'linkOptions' => $this->_linkOptions($element),
             'table' => [
                 'contentToolbar' => [
@@ -650,7 +652,7 @@ private function _linkOptions(?ElementInterface $element = null): array
 
         $sectionSources = $this->_entrySources($element);
         $categorySources = $this->_categorySources($element);
-        $volumeSources = $this->_assetSources();
+        $volumeSources = $this->_assetSources(true);
 
         if (!empty($sectionSources)) {
             $linkOptions[] = [
@@ -673,16 +675,12 @@ private function _linkOptions(?ElementInterface $element = null): array
         }
 
         if (!empty($volumeSources)) {
-            $criteria = [];
-            if ($this->showUnpermittedFiles) {
-                $criteria['uploaderId'] = null;
-            }
             $linkOptions[] = [
                 'label' => Craft::t('ckeditor', 'Link to an asset'),
                 'elementType' => Asset::class,
                 'refHandle' => Asset::refHandle(),
                 'sources' => $volumeSources,
-                'criteria' => $criteria,
+                'criteria' => $this->_assetSelectionCriteria(),
             ];
         }
 
@@ -782,9 +780,10 @@ private function _categorySources(?ElementInterface $element = null): array
     /**
      * Returns the available asset sources.
      *
+     * @param bool $withUrlsOnly Whether to only return volumes that have filesystems that have public URLs
      * @return string[]
      */
-    private function _assetSources(): array
+    private function _assetSources(bool $withUrlsOnly = false): array
     {
         if (!$this->availableVolumes) {
             return [];
@@ -801,6 +800,11 @@ private function _assetSources(): array
             $volumes = $volumes->filter(fn(Volume $volume) => $userService->checkPermission("viewAssets:$volume->uid"));
         }
 
+        if ($withUrlsOnly) {
+            // only allow volumes that belong to FS that have public URLs
+            $volumes = $volumes->filter(fn(Volume $volume) => $volume->getFs()->hasUrls);
+        }
+
         $sources = $volumes
             ->map(fn(Volume $volume) => "volume:$volume->uid")
             ->values()
@@ -815,6 +819,20 @@ private function _assetSources(): array
         return $sources;
     }
 
+    /**
+     * Returns the asset selection criteria.
+     *
+     * @return array
+     */
+    private function _assetSelectionCriteria(): array
+    {
+        $criteria = [];
+        if ($this->showUnpermittedFiles) {
+            $criteria['uploaderId'] = null;
+        }
+        return $criteria;
+    }
+
     /**
      * Returns custom element sources keys for given element type.
      *

src/web/assets/ckeditor/src/image/imageinsert/imageinsertui.js

@@ -15,7 +15,7 @@ export default class CraftImageInsertUI extends ImageInsertUI {
 
   init() {
     // Make sure there are linked volumes
-    if (!this._linkOption) {
+    if (!this._assetSources) {
       console.warn(
         'Omitting the "image" CKEditor toolbar button, because there aren’t any permitted volumes.',
       );
@@ -31,11 +31,8 @@ export default class CraftImageInsertUI extends ImageInsertUI {
     componentFactory.add('imageInsert', componentCreator);
   }
 
-  get _linkOption() {
-    const linkOptions = this.editor.config.get('linkOptions');
-    return linkOptions.find(
-      (option) => option.elementType === 'craft\\elements\\Asset',
-    );
+  get _assetSources() {
+    return this.editor.config.get('assetSources');
   }
 
   _createToolbarImageButton(locale) {
@@ -53,16 +50,17 @@ export default class CraftImageInsertUI extends ImageInsertUI {
   }
 
   _showImageSelectModal() {
+    const sources = this._assetSources;
     const editor = this.editor;
     const config = editor.config;
-    const linkOption = this._linkOption;
-
-    Craft.createElementSelectorModal(linkOption.elementType, {
-      storageKey: `ckeditor:${this.pluginName}:${linkOption.elementType}`,
-      sources: linkOption.sources,
-      criteria: Object.assign({}, linkOption.criteria, {
-        kind: 'image',
-      }),
+    const criteria = Object.assign({}, config.get('assetSelectionCriteria'), {
+      kind: 'image',
+    });
+
+    Craft.createElementSelectorModal('craft\\elements\\Asset', {
+      storageKey: `ckeditor:${this.pluginName}:'craft\\elements\\Asset'`,
+      sources,
+      criteria,
       defaultSiteId: config.get('elementSiteId'),
       transforms: config.get('transforms'),
       multiSelect: true,