Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger schema partial patching. Swagger schema validation. #43

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

trezorg
Copy link

@trezorg trezorg commented Feb 28, 2018

It would be useful to redefine or update global swagger schema by endpoint swagger definition.
Also it is possible to validate swagger schema. Also dropped 3.4 support.

regqueryvalueex and others added 3 commits February 27, 2018 23:00
… introducing a new string argument for **setup_swagger** function **swagger_validator_url** with default value **''**. Documentation is updated.
Allows redefine the swagger description in the code for needed endpoints
@codecov-io
Copy link

codecov-io commented Feb 28, 2018

Codecov Report

Merging #43 into master will increase coverage by 2.31%.
The diff coverage is 95.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   92.98%   95.29%   +2.31%     
==========================================
  Files           4        5       +1     
  Lines         114      319     +205     
==========================================
+ Hits          106      304     +198     
- Misses          8       15       +7
Impacted Files Coverage Δ
aiohttp_swagger/helpers/__init__.py 100% <100%> (ø) ⬆️
aiohttp_swagger/helpers/decorators.py 100% <100%> (ø) ⬆️
aiohttp_swagger/__init__.py 100% <100%> (+2.63%) ⬆️
aiohttp_swagger/helpers/validation.py 94.87% <94.87%> (ø)
aiohttp_swagger/helpers/builders.py 92.47% <97.22%> (+2.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af93ac...2548a9c. Read the comment docs.

@trezorg trezorg force-pushed the master branch 9 times, most recently from db0273b to 08f089e Compare February 28, 2018 14:34
@trezorg trezorg force-pushed the master branch 8 times, most recently from e19963c to 7d72e74 Compare March 3, 2018 20:22
@CyberLight
Copy link

@trezorg Thank you! I used the code from your PR, and it saved my time!
May be some changes need:

  • Draft4Validator to Draft7Validator
  • if issubclass(handler, web.View) and route.method == METH_ANY: to if inspect.isclass(handler) and issubclass(handler, web.View) and route.method == METH_ANY:

P.S.: Very cool PR, but I don’t understand why this PR hasn't been accepted until now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants