Adding edge case tests for overlaps operators. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These new tests have been run successfully on the Java engine (see Cooking with CQL session 83) |
suyashkumar
approved these changes
Jun 2, 2024
| <test name="IntegerIntervalOverlapsTrue3"> | ||
| <expression>Interval[10, 15] overlaps Interval[4, 10]</expression> | ||
| <output>true</output> | ||
| </test> |
There was a problem hiding this comment.
(non blocking thought): would it make sense to add a few tests here (in another PR) for intervals with exclusive boundaries for completeness? it essentially would test that folks are indeed implementing overlaps with the proper start/end semantics.
There was a problem hiding this comment.
Yep, I think that makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few edge case tests for the overlaps, overlaps before and overlaps after operators. These tests are related to the technical correction submitted to the specification here:
https://jira.hl7.org/browse/FHIR-46051
The author's guide is unclear about the intended interpretation of "overlaps before" and "overlaps after", whereas the reference and logical specification are both clear. These tests cover the edges of: