Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple ordering of POST calls by resource type #534

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

echicoine-icf
Copy link
Contributor

@echicoine-icf echicoine-icf commented Oct 1, 2024

When running Refresh and specifying a FHIR server to persist the resources to, I found resources that would fail in the initial attempt, but POST in the second attempt, indicating a dependency on some other resource to POST first. I've identified an order for these resources to be posted in: Bundle, Library Dependencies, Value Sets, Tests, and Patient Group files. With this grouping of resources and creating an order in which they are sent to the server, the initial attempt at posting the resources is far more successful and consistent.

When calling HttpClientUtils.post, the enum HttpPOSTResourceType can be specified. When executing the tasks, HttpClientUtils.resourceTypePostOrder is used to execute each group of tasks in the order specified.

  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 84.46602% with 16 lines in your changes missing coverage. Please review.

Project coverage is 21.97%. Comparing base (eb2ec44) to head (52d3efb).

Files with missing lines Patch % Lines
...opencds/cqf/tooling/utilities/HttpClientUtils.java 85.89% 6 Missing and 5 partials ⚠️
...rg/opencds/cqf/tooling/measure/MeasureBundler.java 84.21% 2 Missing and 1 partial ⚠️
...opencds/cqf/tooling/processor/AbstractBundler.java 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #534      +/-   ##
============================================
+ Coverage     21.85%   21.97%   +0.11%     
- Complexity     1673     1681       +8     
============================================
  Files           297      297              
  Lines         25392    25432      +40     
  Branches       4004     4011       +7     
============================================
+ Hits           5550     5588      +38     
+ Misses        18922    18920       -2     
- Partials        920      924       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@echicoine-icf
Copy link
Contributor Author

echicoine-icf commented Oct 3, 2024

Example of the progress summary reported to users:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant