Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ValueSetRef.preserve to true for included value sets #1409

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

antvaset
Copy link
Contributor

@antvaset antvaset commented Aug 29, 2024

Closes #1407.

Starting with version 1.5, ValueSetRefs need to have preserve set to true during translation so that ValueSetRefEvaluator does not expand them during execution. Currently, this is only applied to the ValueSetRefs that point to value sets from the same library and not when the value set comes from an included library (i.e. not when ValueSetRefs are constructed from imported ValueSetDefs). The fix is to set ValueSetRef.preserve to true in both cases.

@antvaset antvaset changed the title #1407: Set preserve to true for included value sets Set ValueSetRef.preserve to true for included value sets Aug 29, 2024
Copy link

Formatting check succeeded!

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.73%. Comparing base (05c2bd3) to head (917ea2c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1409      +/-   ##
============================================
- Coverage     63.73%   63.73%   -0.01%     
- Complexity     2665     2666       +1     
============================================
  Files           494      494              
  Lines         27834    27836       +2     
  Branches       5527     5528       +1     
============================================
+ Hits          17740    17741       +1     
- Misses         7851     7852       +1     
  Partials       2243     2243              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antvaset antvaset marked this pull request as ready for review August 29, 2024 21:01
@JPercival JPercival enabled auto-merge (squash) August 30, 2024 20:24
@JPercival JPercival merged commit dd98ccc into master Aug 30, 2024
5 checks passed
@JPercival JPercival deleted the valuesetref-preserve branch August 30, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CQL Expand Valueset Issue
3 participants