-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle overloaded forward function declarations. #1213
Merged
JPercival
merged 19 commits into
cqframework:master
from
lukedegruchy:1191-overloaded-function-declarations-fail-to-resolve-3
Oct 11, 2023
Merged
Handle overloaded forward function declarations. #1213
JPercival
merged 19 commits into
cqframework:master
from
lukedegruchy:1191-overloaded-function-declarations-fail-to-resolve-3
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…class to ensure equivalence between the calling and called functions instead of previously just matching by name. Handle various edge cases such as implicit conversions and choice types. Add pre compile (function header) functionality to CqlPreprocessorVisitor. Refactor Cql2ElmVisitor to share functionality with CqlPreprocessorVisitor. Add several new unit tests to validate the new functionality.
JPercival
requested changes
Sep 20, 2023
Src/java/cql-to-elm/src/main/java/org/cqframework/cql/cql2elm/preprocessor/LibraryInfo.java
Outdated
Show resolved
Hide resolved
…LibraryBuilder. Enhance the checking for duplicate functions not to rely solely on equals/hashCode but to consider the operand type.
@lukedegruchy - I merged master into this branch and fixed a minor typo. However, that exposed an issue:
One potential fix for that is to update the PreProcessor to do all that type resolution itself, store that information on the library builder, and then override the Cql2ElmVisitor to no-op for visiting TypeSpecifiers. |
…nd retrieving them in the ELM visitor, ensuring errors are cached as well instead of duplicated.
JPercival
approved these changes
Oct 3, 2023
mdnazmulkarim
approved these changes
Oct 4, 2023
…ction-declarations-fail-to-resolve-3
…ction-declarations-fail-to-resolve-3
…one() in order to get all SignatureLevel None test cases passing again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1191