Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to support later vscode versions #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NixM0nk3y
Copy link

Bump modules and the current vscode revision.

Should help resolve https://github.com/cpwood/Pico-Go/issues/122 .

Rebuild the extension and confirmed working on win32 / vscode 1.66.2

@kevindawson
Copy link

kevindawson commented Apr 24, 2022

@NixM0nk3y this is cool - Thanks
Please can you kick me in direction of how-to ReBuild so that I can test on Linux & arm64
then others can follow
@cpwood - ping - push - :)

@NixM0nk3y
Copy link
Author

The updated extensions are commited into the develop branch of my testing fork. You should be able to follow the extension rebuild instructions to generate a local vsix to install.

@kevindawson
Copy link

kevindawson commented Apr 24, 2022

@NixM0nk3y Thank you for the kick :)

@kevindawson
Copy link

@NixM0nk3y
I cloned your copy of Pico-Go switched to Develop branch - several iterations of npm audit fix
14 vulnerabilities (2 low, 10 high, 2 critical)

~/github/Pico-Go$ code --trace-deprecation --install-extension pico-go-1.4.4.vsix
Warning: 'trace-deprecation' is not in the list of known options, but still passed to Electron/Chromium.
Installing extensions...
(node:91209) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `code --trace-deprecation ...` to show where the warning was created)
Extension 'pico-go-1.4.4.vsix' was successfully installed.

Looks like there is more to do - my first time hacking around with node.js seams like fun

@Lak4CYUT
Copy link

Thank guys. Hope pico-go can be upgrade soon. Otherwise I need to frozen my vscode upgrade..

@SubaruArai
Copy link

@cpwood ping

@wzaremba
Copy link

@NixM0nk3y can you please share the vsix file? for any reason I cannot build it by myself. What should I put into program in launch.json? I am starting to play with node...sorry for lame Q

@kevindawson
Copy link

@NixM0nk3y

You should be able to follow the extension rebuild instructions to generate a local vsix to install.

can you not just build it locally -> then drop pico_go_xxx.vsix into your code -> then do a pull request -> followed by an Issue ticket to advertise its presence
then we can all clap n cheer and whoop and say thank-you

@NixM0nk3y
Copy link
Author

@NixM0nk3y can you please share the vsix file? for any reason I cannot build it by myself. What should I put into program in launch.json? I am starting to play with node...sorry for lame Q

I've build a unofficial version and published here for folks who don't have a nodejs build environment, should hopefully unblock some pico makers until this extension finds a active maintainer.

@kevindawson
Copy link

@NixM0nk3y

  • clap n cheer
  • whoop

thank-you

@kevindawson
Copy link

kevindawson commented Jun 12, 2022

@NixM0nk3y
don't for get to tell the world -> https://github.com/cpwood/Pico-Go/issues
you could also add a link in each relevant Issue
to help those less capable than you
thanks in adv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node module version is outdated on VSCode v1.66.
5 participants