Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish sha1 nist cavs testing #22

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Finish sha1 nist cavs testing #22

merged 8 commits into from
Oct 21, 2024

Conversation

ckormanyos
Copy link
Collaborator

No description provided.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://22.crypt.prtest2.cppalliance.org/libs/crypt/doc/html/index.html

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3ab6262) to head (2be2c7f).
Report is 30 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop       #22    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           12        13     +1     
  Lines          798       898   +100     
  Branches       101       116    +15     
==========================================
+ Hits           798       898   +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mborland
Copy link
Member

@sdarwin If possible can you please change the cppalliance-bot to only build the docs when there is a modification in the doc folder? Right now it looks to be building on every commit. Thanks.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://22.crypt.prtest2.cppalliance.org/libs/crypt/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://22.crypt.prtest2.cppalliance.org/libs/crypt/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://22.crypt.prtest2.cppalliance.org/libs/crypt/doc/html/index.html

1 similar comment
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://22.crypt.prtest2.cppalliance.org/libs/crypt/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://22.crypt.prtest2.cppalliance.org/libs/crypt/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://22.crypt.prtest2.cppalliance.org/libs/crypt/doc/html/index.html

@ckormanyos
Copy link
Collaborator Author

Hi Matt (@mborland) it seems like CI runs really well so far. I was thinking we could activete branch protection such that sll checks must pass before merging. As a last shot, you can allow force-pushes.

Your choice.

@sdarwin
Copy link
Collaborator

sdarwin commented Oct 21, 2024

@mborland , fixed. Let's see if that works as expected.

Concerning other cppalliance repos that use mrdocs, it's my understanding mrdocs will build documentation from the codebase, and any commit affects that. It's not clear what the default should be... I have set the general default to always-build, and then adjusted the crypt repo to be more cautious.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://22.crypt.prtest2.cppalliance.org/libs/crypt/doc/html/index.html

@mborland
Copy link
Member

@mborland , fixed. Let's see if that works as expected.

Concerning other cppalliance repos that use mrdocs, it's my understanding mrdocs will build documentation from the codebase, and any commit affects that. It's not clear what the default should be... I have set the general default to always-build, and then adjusted the crypt repo to be more cautious.

Thanks Sam. I do not use Mr. Docs in this repo, it's still manually updated Asciidocs.

@mborland
Copy link
Member

Hi Matt (@mborland) it seems like CI runs really well so far. I was thinking we could activete branch protection such that sll checks must pass before merging. As a last shot, you can allow force-pushes.

Your choice.

Now that CUDA is in I think it should be stable for a while so that's fine. Do you want to add the STM QEMU run again? That's the only thing from decimal that I left out.

@ckormanyos
Copy link
Collaborator Author

Do you want to add the STM QEMU run again?

Yeah, in a few weeks, I'll probably do at least a bunch of hashing in theer on the metal and setup a CI-matrix on the hash-type.

@ckormanyos ckormanyos merged commit 5894397 into develop Oct 21, 2024
69 checks passed
@ckormanyos ckormanyos deleted the sha1_cavs_testing branch October 21, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants