Add basic MD5 and project structure #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
mborland
force-pushed
the
md5_2
branch
3 times, most recently
from
c6c9fdb to
1863070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a trivial, unoptimized version of MD5. More importantly it pulls in all the CI testing that we are going to need, and adds the general framework to the library.
@ckormanyos I think this a good example of all the interfaces we should offer:
const char*, iterator pair,std::string, andstd::string_view. I can't really think of anything else but having all of those would be pretty easy for the end user.I think we can have it where CUDA is allowed to calculate the complete MD5 on a device, but we can't split up the 512-bit blocks since the return values depend on the previous iteration.
All of automation is based off decimal so if there's more warnings or errors we want to add now is the time.