Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clang-tools Dockerfiles #64

Merged
merged 5 commits into from
Sep 24, 2023
Merged

Conversation

shenxianpeng
Copy link
Collaborator

fixes #63 #62

@2bndy5
Copy link

2bndy5 commented Sep 23, 2023

Which versions are being dropped? Anything before 9?

@shenxianpeng
Copy link
Collaborator Author

In the beginning, I think the versions before 9 will be dropped, because I think I can not support them in one Dockerfile. later I can pass BASE_IMAGE in docker-bake.hcl, so right now I only drop version 6.0, it has a different version naming conversion than the others (7, 8, 9, etc.) and needs special handling, which I don't think is necessary to support anymore.

@shenxianpeng shenxianpeng merged commit fdb5286 into master Sep 24, 2023
3 checks passed
@shenxianpeng shenxianpeng deleted the feature/refactor-dockerfiles branch September 24, 2023 14:24
@shenxianpeng shenxianpeng added the enhancement New feature or request label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for 6.0 version of clang-tools
2 participants