Using DESTINATION_GITHUB_USERNAME instead of USER_NAME for cloning and pushing #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel that using variable
USER_NAME
in thegit clone
andgit push
commands is not correct, since it is used also to set theuser.name
property using 'git config`.Typically, this property contains real user information (name and surname and such), which differs from the GitHub username.
For example, I typically set it to
"Gabriele Ara"
.This creates a bunch of problems when using this option in this action, because:
I feel that simply changing it to
DESTINATION_GITHUB_USERNAME
would solve the issue.