Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using DESTINATION_GITHUB_USERNAME instead of USER_NAME for cloning and pushing #46

Closed
wants to merge 1 commit into from

Conversation

gabrieleara
Copy link

@gabrieleara gabrieleara commented Nov 16, 2021

I feel that using variable USER_NAME in the git clone and git push commands is not correct, since it is used also to set the user.name property using 'git config`.

Typically, this property contains real user information (name and surname and such), which differs from the GitHub username.
For example, I typically set it to "Gabriele Ara".

This creates a bunch of problems when using this option in this action, because:

  • it has spaces in it (which git/curl does not like at all);
  • it does not correspond to any github username (my username is close but not quite the same).

I feel that simply changing it to DESTINATION_GITHUB_USERNAME would solve the issue.

@cpina
Copy link
Owner

cpina commented Jan 22, 2022

Thanks for the PR - I will consider it but first I want to write some tests to avoid regressions in the current version. That's why I haven't done it yet (and lack of time for doing them :-) )

@cpina cpina linked an issue Jan 22, 2022 that may be closed by this pull request
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests
2 participants