Local Deployment + Location management + HEALTH connectivity + bug fixes #229
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 7056958 | Triggered | Generic High Entropy Secret | cbccc5b | lib/local/local_study_protocol_manager.dart | View secret |
| 7056958 | Triggered | Generic High Entropy Secret | b1882d0 | lib/local/local_study_protocol_manager.dart | View secret |
| 7056958 | Triggered | Generic High Entropy Secret | b1882d0 | assets/carp/resources/protocol.json | View secret |
| 9412144 | Triggered | Generic High Entropy Secret | b1882d0 | lib/local/local_study_protocol_manager.dart | View secret |
| 9412144 | Triggered | Generic High Entropy Secret | cbccc5b | lib/local/local_study_protocol_manager.dart | View secret |
| 7056957 | Triggered | Generic High Entropy Secret | b1882d0 | assets/carp/resources/protocol.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
| : firstRoute), | ||
| redirect: (context, state) { | ||
| if (bloc.deploymentMode != DeploymentMode.local) { | ||
| // check authentication to CAWS |
There was a problem hiding this comment.
i'd say remove unnecessary comments, it's implicit in the logic
| redirect: (context, state) => bloc.hasInformedConsentBeenAccepted | ||
| ? firstRoute | ||
| : (bloc.studyId == null ? InvitationListPage.route : null), | ||
| // redirect: (context, state) => bloc.hasInformedConsentBeenAccepted | ||
| // ? firstRoute | ||
| // : (bloc.studyId == null ? InvitationListPage.route : null), |
There was a problem hiding this comment.
what happens if the user gets redirected to the ic page through deep linking for example, do they have to accept it again?
There was a problem hiding this comment.
I would say yes - the reason to navigate to the IC is to show it to the user (again). This is actually a missing features right now, that the user should be able to go back and see the IC - e.g. from the setting menu.
| @@ -40,14 +40,17 @@ import 'package:carp_esense_package/esense.dart'; | |||
| import 'package:carp_polar_package/carp_polar_package.dart'; | |||
| import 'package:research_package/research_package.dart'; | |||
| import 'package:cognition_package/cognition_package.dart'; | |||
| import 'package:carp_health_package/health_package.dart'; | |||
| // import 'package:health/health.dart'; | |||
There was a problem hiding this comment.
remove dead code comments
| @@ -46,7 +46,7 @@ dependencies: | |||
| go_router: ^13.0.0 | |||
| flutter_svg: ^2.0.4 | |||
| flutter_blue_plus: ^1.15.5 | |||
| intl: ^0.18.1 | |||
| intl: '>=0.18.0 <1.0.0' | |||
There was a problem hiding this comment.
are you sure about this?
There was a problem hiding this comment.
Yes - there has been some discussion on the intl package and problem with Flutter - not solved yet, so this is the current work-around.
|
xcode is not building with these commits... and also gitguardian is complaining about exposed secrets, these need to be remedied |
|
maybe next time it would be beneficial to keep PRs on a smaller scope so there's not 2500 code changes to look through... |
I had the same issue last week(uploaded secrets). I think its better if we changed the history of the commits too so that the keys do not appear in old commits. I fixed this using this link. It's a tool that automates a lot of the process but I still needed to do some things on my own. |
I agree - but the problem is that often you "touch" many files just in order to make a "small" change.. |
Sure, but cannot accept this PR before the app is properly building on iOS. |
|
This was included in PR #234 |
This PR :
Also updated API + README documentation in places.