Use secrets: inherit in workflow

cph-cachet · Jun 23, 2023 · 3300c56 · 3300c56
1 parent 5d93442
commit 3300c56
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 19 deletions.
diff --git a/.github/workflows/deploy_play_store.yml b/.github/workflows/deploy_play_store.yml
@@ -71,26 +71,10 @@ jobs:
           KEYSTORE_STORE_PASSWORD: ${{ secrets.KEYSTORE_STORE_PASSWORD }}
         working-directory: android
 
-      # debugging
-      - name: Print env
-        run: |
-          ls -la
-          ls -la app/
-          cat key.properties
-          cat app/upload-keystore.jks
-          echo $PLAY_STORE_UPLOAD_KEY
-        working-directory: android
-        env:
-          PLAY_STORE_UPLOAD_KEY: ${{ secrets.PLAY_STORE_UPLOAD_KEY }}
-          KEYSTORE_KEY_ALIAS: ${{ secrets.KEYSTORE_KEY_ALIAS }}
-          KEYSTORE_KEY_PASSWORD: ${{ secrets.KEYSTORE_KEY_PASSWORD }}
-          KEYSTORE_STORE_PASSWORD: ${{ secrets.KEYSTORE_STORE_PASSWORD }}
-
       # Build and deploy with Fastlane to Beta track on pushses to branches
       # and to Production track on tags.
       - name: Deploy to Play Store
         run: bundle exec fastlane ${{ inputs.lane || 'beta' }}
-        # if: false
         env:
           PLAY_STORE_JSON_KEY: ${{ secrets.PLAY_STORE_JSON_KEY }}
         working-directory: android
diff --git a/.github/workflows/deploy_play_store_beta.yml b/.github/workflows/deploy_play_store_beta.yml
@@ -4,7 +4,6 @@ on:
   push:
     branches:
       - 'master'
-      - 'LarsRefsgaard/issue163'
 
 
 

diff --git a/.github/workflows/deploy_play_store_prod.yml b/.github/workflows/deploy_play_store_prod.yml
@@ -12,5 +12,6 @@ permissions: read-all
 jobs:
   workflow_run:
     uses: cph-cachet/carp-studies-app/.github/workflows/deploy_play_store.yml@master
+    secrets: inherit
     with:
       lane: 'promote_to_production'
diff --git a/android/app/build.gradle b/android/app/build.gradle
@@ -13,7 +13,7 @@ if (flutterRoot == null) {
 
 def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
 if (flutterVersionCode == null) {
-    flutterVersionCode = '18'
+    flutterVersionCode = '19'
 }
 
 def flutterVersionName = localProperties.getProperty('flutter.versionName')

diff --git a/android/fastlane/Fastfile b/android/fastlane/Fastfile
@@ -24,7 +24,7 @@ platform :android do
   desc "Submit a new beta build to Google Play"
   lane :beta do
     # TODO: Re-enable deferred components once https://github.com/flutter/gallery/issues/926 is fixed
-    sh "flutter build appbundle --no-deferred-components"
+    sh "flutter build appbundle -v --no-deferred-components"
     upload_to_play_store(
       track: 'beta',
       aab: '../build/app/outputs/bundle/release/app-release.aab',