[VO-889] fix(PermissionDialog): Show overflow icon on iOS #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cballevre
requested review from
JF-Cozy,
Merkur39,
Ldoppea and
zatteo
as code owners
cballevre
force-pushed
the
fix/show-overflow-on-ios
branch
from
944fb3d to
3f78f36
Compare
JF-Cozy
reviewed
Jul 9, 2024
| @@ -455,7 +455,7 @@ export const makeLightNormalOverrides = theme => ({ | |||
| maxWidth: '800px' | |||
| } | |||
| }, | |||
| '&.overflow': { | |||
| '&.overflow, &.overflow .cozyDialogContent': { | |||
There was a problem hiding this comment.
si ça t'ennuie pas je préfère séparer les éléments, c'est ce qu'on fait partout et je trouve que la lisibilité est meilleure, ça évite de rater un truc en lisant vite...
'&.overflow': {
overflowY: 'visible !important' // Allow the icon to overflow the dialog, otherwise it will be cut off,
'& .cozyDialogContent': {
overflowY: 'visible !important' // Allow the icon to overflow the dialog, otherwise it will be cut off
}
}
Par contre ça pose quand même question 🤔 est-ce que les deux sont vraiment nécessaires ?
There was a problem hiding this comment.
Unfortunately I need both conditions for it to work. I separated it as you suggest
cballevre
force-pushed
the
fix/show-overflow-on-ios
branch
from
3f78f36 to
8e73f83
Compare
MUI adds a `-webkit-overflow-scrolling` property to manage scrolling on iOS. This is act as a counter-effect to `overflow-y: visible` of the parent to display the icon beyond the modal.
cballevre
force-pushed
the
fix/show-overflow-on-ios
branch
from
8e73f83 to
c4507ff
Compare
JF-Cozy
approved these changes
Jul 10, 2024
|
🎉 This PR is included in version 110.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MUI adds a
-webkit-overflow-scrollingproperty to manage scrolling on iOS on the content. This is act as a counter-effect tooverflow-y: visibleof the parent to display the icon beyond the modal.