Merge pull request #1105 from cozy/fix/RmTARGETref

fix: Do not use __TARGET__ on a lib
cozy · Jul 16, 2019 · 3dd9228 · 3dd9228
2 parents b426cbc + 895b8e4
commit 3dd9228
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -181,7 +181,6 @@
     },
     "globals": {
       "__ALLOW_HTTP__": false,
-      "__TARGET__": "browser",
       "cozy": {}
     },
     "testURL": "http://localhost/",

diff --git a/react/AppLinker/Readme.md b/react/AppLinker/Readme.md
@@ -15,7 +15,6 @@ As it uses the render props pattern, it is flexible and can be used to build com
 anchor.
 
 ```
-window.__TARGET__ = 'web';
 
 <AppLinker slug='banks' href='http://dalailama-banks.mycozy.cloud'>{
   ({ onClick, href, name }) => (

diff --git a/react/AppLinker/index.jsx b/react/AppLinker/index.jsx
@@ -1,5 +1,3 @@
-/* global __TARGET__ */
-
 import React from 'react'
 import PropTypes from 'prop-types'
 import {
@@ -33,7 +31,7 @@ export class AppLinker extends React.Component {
   }
 
   componentDidMount() {
-    if (typeof __TARGET__ !== 'undefined' && __TARGET__ === 'mobile') {
+    if (isMobileApp()) {
       this.checkAppAvailability()
     }
   }

diff --git a/react/AppLinker/index.spec.jsx b/react/AppLinker/index.spec.jsx
@@ -57,7 +57,7 @@ describe('app icon', () => {
   let spyConsoleError, openNativeFromNativeSpy, appSwitchMock
 
   beforeEach(() => {
-    global.__TARGET__ = 'browser'
+    isMobileApp.mockReturnValue(false)
     spyConsoleError = jest.spyOn(console, 'error')
     spyConsoleError.mockImplementation(message => {
       if (message.lastIndexOf('Warning: Failed prop type:') === 0) {
-Original file line number
+Diff line change
@@ Expand Up @@
     anchor.
     ```
-    window.__TARGET__ = 'web';
     <AppLinker slug='banks' href='http://dalailama-banks.mycozy.cloud'>{
       ({ onClick, href, name }) => (
@@ Expand Down @@