fix(search.js): rename underMaintenance to showMaintenance

BREAKING CHANGE: You need to use showMaintenance instead underMaintenance matcher in AppSection filters
cozy · Dec 15, 2022 · 295058a · 295058a
1 parent 83cb5c5
commit 295058a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/react/AppSections/search.js b/react/AppSections/search.js
@@ -27,8 +27,9 @@ const doctypeMatcher = doctype => app => {
 }
 const pendingUpdateMatcher = () => app => !!app.availableVersion
 
-const underMaintenanceMatcher = isUnderMaintenance => app => {
-  return (app.maintenance !== undefined) === isUnderMaintenance
+const showMaintenanceMatcher = isShowMaintenance => app => {
+  if (isShowMaintenance) return true
+  return app.maintenance === undefined
 }
 
 const searchAttrToMatcher = {
@@ -37,7 +38,7 @@ const searchAttrToMatcher = {
   tag: tagMatcher,
   doctype: doctypeMatcher,
   pendingUpdate: pendingUpdateMatcher,
-  underMaintenance: underMaintenanceMatcher
+  showMaintenance: showMaintenanceMatcher
 }
 
 /**

diff --git a/react/AppSections/search.spec.js b/react/AppSections/search.spec.js
@@ -45,17 +45,19 @@ describe('makeMatcherFromSearch', () => {
     expect(mockApps.filter(matcher)).toMatchSnapshot()
   })
 
-  it('should filter correctly when under maintenance is false', () => {
-    const matcher = makeMatcherFromSearch({ underMaintenance: false })
+  it('should filter correctly when show maintenance is false', () => {
+    const matcher = makeMatcherFromSearch({ showMaintenance: false })
     expect(mockMaintenanceApps.filter(matcher)).toStrictEqual([
       { slug: 'collect' },
       { slug: 'drive' }
     ])
   })
 
-  it('should filter correctly when under maintenance is true', () => {
-    const matcher = makeMatcherFromSearch({ underMaintenance: true })
+  it('should filter correctly when show maintenance is true', () => {
+    const matcher = makeMatcherFromSearch({ showMaintenance: true })
     expect(mockMaintenanceApps.filter(matcher)).toStrictEqual([
+      { slug: 'collect' },
+      { slug: 'drive' },
       {
         maintenance: {
           flag_disallow_manual_exec: true,