Allow to patch password/expires_at for permissions #4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nono
force-pushed
the
patch-permissions
branch
from
0d9346c to
bd682ef
Compare
Merkur39
reviewed
Jan 16, 2025
This was referenced Jan 17, 2025
This issue was discovered by @Merkur39. When creating an io.cozy.permissions for a share by link, the expires_at field was set to null in CouchDB, even if the field was declared as omitempty. A nil pointer to a time.Time is not considered by Go as an empty value for a field of the type interface{}. So, we need to use the empty value of type interface{} instead to fix the JSON marshaling.
nono
force-pushed
the
patch-permissions
branch
from
bf120d0 to
64f57e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.