Add a route to ensure the vault is initialized #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
approved these changes
Jan 8, 2024
Ldoppea
added a commit
to cozy/cozy-pass-web
that referenced
this pull request
Jan 23, 2024
In a previous commit we changed the bitwarden client's type from `webapp` to `web` This had a side effect on onboarding that would not trigger migration from konnectors accounts to ciphers as this is prevented on `web` clients (because cozy-keys-lib is also flagged as a `web` client) This is a requirement for setting `extension_installed` flag to `true` The result was the onboarding screen to be always displayed when accessing cozy-pass-web To fix this, the cozy-stack now has a new entry point `/settings/vault` that allows to enforce the migration from cozy-pass-web even if its client is a `web` one Related PR: #109 Related PR: cozy/cozy-stack#4285 Related PR: cozy/cozy-stack#4303
Ldoppea
added a commit
to cozy/cozy-pass-web
that referenced
this pull request
Jan 23, 2024
In a previous commit we changed the bitwarden client's type from `webapp` to `web` This had a side effect on onboarding that would not trigger migration from konnectors accounts to ciphers as this is prevented on `web` clients (because cozy-keys-lib is also flagged as a `web` client) This is a requirement for setting `extension_installed` flag to `true` The result was the onboarding screen to be always displayed when accessing cozy-pass-web To fix this, the cozy-stack now has a new entry point `/settings/vault` that allows to enforce the migration from cozy-pass-web even if its client is a `web` one We want to call this endpoint at the end of onboarding Related PR: #109 Related PR: cozy/cozy-stack#4285 Related PR: cozy/cozy-stack#4303
Ldoppea
added a commit
to cozy/cozy-pass-web
that referenced
this pull request
Feb 5, 2024
In a previous commit we changed the bitwarden client's type from `webapp` to `web` This had a side effect on onboarding that would not trigger migration from konnectors accounts to ciphers as this is prevented on `web` clients (because cozy-keys-lib is also flagged as a `web` client) This is a requirement for setting `extension_installed` flag to `true` The result was the onboarding screen to be always displayed when accessing cozy-pass-web To fix this, the cozy-stack now has a new entry point `/settings/vault` that allows to enforce the migration from cozy-pass-web even if its client is a `web` one We want to call this endpoint at the end of onboarding Related PR: #109 Related PR: cozy/cozy-stack#4285 Related PR: cozy/cozy-stack#4303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.