Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Build cozy-device-helper first because of dep in cozy-intent #1582

Merged
merged 1 commit into from
May 9, 2022

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented May 6, 2022

Since cozy-intent needs a build version of cozy-device-helper to be
built, we update the build command.

Since cozy-intent need a build version of cody-device-helper to be
built, we need to build it first
@@ -18,7 +18,7 @@
"lint": "eslint --ext js,jsx,ts,tsx .",
"lint:md": "remark . -o",
"test": "lerna run --concurrency 1 test",
"build": "lerna run --parallel build",
"build": "lerna run --scope cozy-device-helper build && lerna run --parallel --ignore cozy-device-helper build",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering what have changed inside cozy-intent to get this error. We need to investigate that point one day. Do you think it diserve a Github issue? 🤔

Copy link
Contributor Author

@JF-Cozy JF-Cozy May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pourquoi pas oui 👍 => #1591

@JF-Cozy JF-Cozy merged commit 8cae6d1 into master May 9, 2022
@JF-Cozy JF-Cozy deleted the chore/lerna branch May 9, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants