feat: Trigger replication on appstate changes and realtime events #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
changed the title
2 tasks
Ldoppea
force-pushed
the
feat/remove_old_storage
branch
from
b2a3b4e to
b87dafb
Compare
Ldoppea
force-pushed
the
feat/trigger_replication_on_appstate_and_realtime
branch
2 times, most recently
from
f50d62d to
11582fc
Compare
zatteo
approved these changes
Jan 16, 2025
paultranvan
approved these changes
Jan 16, 2025
| offlineDoctypes.forEach(doctype => { | ||
| realtime.subscribe('created', doctype, triggerReplicationCreated) | ||
| realtime.subscribe('updated', doctype, triggerReplicationUpdated) | ||
| realtime.subscribe('deleted', doctype, triggerReplicationDeleted) |
There was a problem hiding this comment.
I realize we trigger a full replication on all doctypes for any realtime change, while we probably should only replicate for the concerned doctype, to save resources. But this is an improvement that can be made for later
There was a problem hiding this comment.
Yes, we will have to implement something to handle that scenario. For now the replication method always replicate all pouches and no mechanism has been implemented to debounce replications separately.
Ldoppea
force-pushed
the
feat/remove_old_storage
branch
from
b87dafb to
813e264
Compare
Ldoppea
force-pushed
the
feat/trigger_replication_on_appstate_and_realtime
branch
from
11582fc to
77c1030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With previous PouchDB/offline implementation, the app was able to trigger a full replication on application's startup, but then nothing would be replicating until next app's restart
This PR is responsible to implement 2 new scenario:
For both scenario, the replication is debounced for 30s with a maximum of 10min