-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade pouchdb-adapter-react-native-sqlite to V4 and benefits from OPSqlite #1268
Open
Ldoppea
wants to merge
2
commits into
feat/improve_netservice
Choose a base branch
from
feat/opsqlite
base: feat/improve_netservice
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+137
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
zatteo
reviewed
Dec 20, 2024
|
||
// Avoid using node dependent modules | ||
process.browser = true | ||
install() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
zatteo
reviewed
Dec 20, 2024
@@ -3,7 +3,7 @@ | |||
buildscript { | |||
ext { | |||
buildToolsVersion = "34.0.0" | |||
minSdkVersion = 21 | |||
minSdkVersion = 23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to inform the team about this update (which is relevant)
zatteo
approved these changes
Dec 20, 2024
Ldoppea
force-pushed
the
feat/improve_netservice
branch
from
December 20, 2024 14:25
000a188
to
5b4bd63
Compare
Ldoppea
force-pushed
the
feat/opsqlite
branch
from
December 20, 2024 14:25
27cdd56
to
e060e67
Compare
Ldoppea
force-pushed
the
feat/improve_netservice
branch
from
December 20, 2024 14:30
5b4bd63
to
f04e814
Compare
Ldoppea
force-pushed
the
feat/opsqlite
branch
from
December 20, 2024 14:31
e060e67
to
752c4e6
Compare
Ldoppea
force-pushed
the
feat/improve_netservice
branch
from
December 20, 2024 16:43
f04e814
to
f64f70c
Compare
Ldoppea
force-pushed
the
feat/opsqlite
branch
from
December 20, 2024 16:44
752c4e6
to
dc5731e
Compare
Ldoppea
force-pushed
the
feat/improve_netservice
branch
from
December 20, 2024 17:32
f64f70c
to
5c8b9fb
Compare
Ldoppea
force-pushed
the
feat/opsqlite
branch
from
December 20, 2024 17:32
dc5731e
to
22b387a
Compare
Ldoppea
force-pushed
the
feat/improve_netservice
branch
from
December 20, 2024 19:37
5c8b9fb
to
06803ec
Compare
Ldoppea
force-pushed
the
feat/opsqlite
branch
from
December 20, 2024 19:37
22b387a
to
f72aa0f
Compare
Ldoppea
force-pushed
the
feat/improve_netservice
branch
from
December 20, 2024 19:55
06803ec
to
16d9827
Compare
Ldoppea
force-pushed
the
feat/opsqlite
branch
from
December 20, 2024 19:55
f72aa0f
to
8b520b4
Compare
Ldoppea
force-pushed
the
feat/improve_netservice
branch
from
December 20, 2024 20:09
16d9827
to
efa5e6b
Compare
Ldoppea
force-pushed
the
feat/opsqlite
branch
from
December 20, 2024 20:09
8b520b4
to
5aa4813
Compare
Ldoppea
force-pushed
the
feat/improve_netservice
branch
from
December 20, 2024 20:20
efa5e6b
to
39ddcc4
Compare
Ldoppea
force-pushed
the
feat/opsqlite
branch
from
December 20, 2024 20:20
5aa4813
to
728b307
Compare
This upgrade is made possible due to recent RN73 upgrade and will allow to use `op-sqlite` instead of `react-native-quick-sqlite`
Ldoppea
force-pushed
the
feat/improve_netservice
branch
from
January 9, 2025 10:51
39ddcc4
to
0262962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrade is made possible due to recent RN73 upgrade and will allow to use
op-sqlite
instead ofreact-native-quick-sqlite
so we expect performances improvement