fix: Correctly display cozy-apps when the device's Keyboard is displayed #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `KeyboardAvoidingView` component struggles to adapt to Ui layout changes With previous implementation, the one on `CozyAppScreen` would offset the View using the wrong values This is because it is initialized while the `isFirstHalf` variable being false, and so when the `dimensions.statusBarHeight` is applied on top of the View, then the `KeyboardAvoidingView` won't notice the change To prevent this, we want to avoid any change in the UI layout, and so we want the `Animation` to have no impact on it This can be done by moving it outside of the main View
When using `KeyboardAvoidingView` we need to apply `keyboardVerticalOffset` based on the offset between the View that needs to react to keyboard and the top of the screen Otherwise, the View wouldn't move enough when keyboard is displayed and it would appear behind it Related documentation: https://reactnative.dev/docs/keyboardavoidingview#keyboardverticaloffset
zatteo
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Prevent CozyAppScreen's WebView to move after loading animation
The
KeyboardAvoidingViewcomponent struggles to adapt to Ui layout changesWith previous implementation, the one on
CozyAppScreenwould offset the View using the wrong valuesThis is because it is initialized while the
isFirstHalfvariable being false, and so when thedimensions.statusBarHeightis applied on top of the View, then theKeyboardAvoidingViewwon't notice the changeTo prevent this, we want to avoid any change in the UI layout, and so we want the
Animationto have no impact on itThis can be done by moving it outside of the main View
fix: Make cozy-apps handle status bar offset when keyboard is displayed
When using
KeyboardAvoidingViewwe need to applykeyboardVerticalOffsetbased on the offset between the View that needs to react to keyboard and the top of the screenOtherwise, the View wouldn't move enough when keyboard is displayed and it would appear behind it
Related documentation:
https://reactnative.dev/docs/keyboardavoidingview#keyboardverticaloffset