Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Files doctype should appear first in search #3283

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

paultranvan
Copy link
Contributor

When searching through the dataproxy, the default doctype search order is apps, contacts, files, mainly because of their respective volume. It is assumed to have very few apps, and less contacts than files. Therefore, since there is a limit to displayed results, we prefer to display files in last.
This works in the Home search contexte, but not so much in Drive, where it makes sense to have the files displayed first.

When searching through the dataproxy, the default doctype search order
is apps, contacts, files, mainly because of their respective volume.
It is assumed to have very few apps, and less contacts than files.
Therefore, since there is a limit to displayed results, we prefer to
display files in last.
This works in the Home search contexte, but not so much in Drive, where
it makes sense to have the files displayed first.
Copy link

bundlemon bot commented Dec 24, 2024

BundleMon

Files updated (4)
Status Path Size Limits
public/drive.(hash).js
2.06MB (+246B +0.01%) -
vendors/drive.(hash).js
2.29MB (+97B 0%) -
app/drive.(hash).js
160.48KB (+40B +0.02%) -
intents/drive.(hash).js
86.07KB (+29B +0.03%) -
Unchanged files (14)
Status Path Size Limits
public/pdf.worker.entry.(hash).worker.js
345.35KB -
services/qualificationMigration/drive.js
282.48KB -
services/dacc/drive.js
262.13KB -
public/cozy-client-js.js
159.28KB -
public/drive.(hash).min.css
39.46KB -
onlyOffice/slide.pptx
24.83KB -
app-drive.(hash).min.css
10.7KB -
intents-drive.(hash).min.css
8.44KB -
onlyOffice/text.docx
5.85KB -
onlyOffice/spreadsheet.xlsx
5.02KB -
manifest.webapp
1.92KB -
index.html
596B -
intents/index.html
508B -
manifest.json
185B -

Total files change +410B +0.01%

Groups updated (4)
Status Path Size Limits
public/**
2.6MB (+247B +0.01%) -
vendors/**
2.29MB (+97B 0%) -
app/**
160.48KB (+40B +0.02%) -
intents/**
86.56KB (+29B +0.03%) -
Unchanged groups (3)
Status Path Size Limits
services/**
544.62KB -
onlyOffice/**
35.7KB -
img/**
5.85KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@paultranvan
Copy link
Contributor Author

It's christmas: no need to review! 🎅

@paultranvan paultranvan merged commit 4b3d4aa into master Dec 24, 2024
4 checks passed
@paultranvan paultranvan deleted the search-doctype-order branch December 24, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant