Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Handle node 16/node 20 at the same time #3036

Closed
wants to merge 1 commit into from

Conversation

Crash--
Copy link
Contributor

@Crash-- Crash-- commented Dec 14, 2023

Since we're stuck on webpack 4 ATM because of cozy-scripts, we need to fallback to --openssl-legacy-provider for crypto stuff.

But this node option is only available for node 17+. So we've to wrap our cozy-scripts call to a script that check the node version and add or not the option

### 🔧 Tech

* Can develop on node 16 or 20 

Since we're stuck on webpack 4 ATM because of cozy-scripts,
we need to fallback to --openssl-legacy-provider for crypto
stuff.

But this node option is only available for node 17+. So we've
to wrap our cozy-scripts call to a script that check the node
version and add or not the option
Copy link

bundlemon bot commented Dec 14, 2023

BundleMon

Unchanged files (19)
Status Path Size Limits
drive/public/drive.(hash).js
1.68MB 1.7MB
drive/vendors/drive.(hash).js
1.4MB 1.6MB
drive/public/pdf.worker.entry.(hash).worker.j
s
343.37KB 345KB
drive/app/drive.(hash).js
296.26KB 300KB
drive/services/dacc/drive.js
260.8KB 500KB
drive/services/qualificationMigration/drive.j
s
254.88KB 500KB
drive/intents/drive.(hash).js
188.22KB 190KB
drive/public/cozy-client-js.js
158.97KB 160KB
drive/public/drive.(hash).min.css
92.45KB 100KB
drive/app-drive.(hash).min.css
55.47KB 56KB
drive/intents-drive.(hash).min.css
36.89KB 40KB
drive/onlyOffice/slide.pptx
24.82KB 25KB
drive/onlyOffice/text.docx
5.84KB 6KB
drive/onlyOffice/spreadsheet.xlsx
5.01KB 6KB
drive/manifest.webapp
1.89KB 2KB
drive/index.html
531B 1KB
drive/intents/index.html
518B 1KB
drive/img/app-icon.(hash).svg
419B 1KB
drive/manifest.json
184B 1KB

Total files change +16B 0%

Unchanged groups (7)
Status Path Size Limits
drive/public/**
2.27MB +7%
drive/vendors/**
1.4MB +15%
drive/services/**
515.68KB +3%
drive/app/**
296.26KB +10%
drive/intents/**
188.73KB +15%
drive/onlyOffice/**
35.68KB +0.4%
drive/img/**
419B +0.4%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@Crash--
Copy link
Contributor Author

Crash-- commented Dec 14, 2023

Not needed. It's already handled by cozy-script. #3037

@Crash-- Crash-- closed this Dec 14, 2023
@cballevre cballevre deleted the chore/Node20Compatibility branch April 17, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant