feat(move): Allow moving files only shared by link into shared folder #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cballevre
commented
Dec 5, 2023
cballevre
commented
cballevre
force-pushed
the
feat/moving-only-shared-by-link
branch
from
928090e to
86283a0
Compare
BundleMonFiles updated (1)
Unchanged files (18)
Total files change +286B +0.01% Groups updated (1)
Unchanged groups (7)
Final result: ✅ View report in BundleMon website ➡️ |
Crash--
reviewed
Dec 6, 2023
| @@ -229,6 +229,32 @@ describe('MoveModal component', () => { | |||
| }) | |||
|
|
|||
| describe('move shared folder inside another', () => { | |||
| it('should move the shared folder inside another if its by ling', async () => { | |||
There was a problem hiding this comment.
nit:
Suggested change
| it('should move the shared folder inside another if its by ling', async () => { | |
| it('should move the shared folder inside another if its by link', async () => { |
Crash--
reviewed
Dec 6, 2023
| /** | ||
| * Returns whether one of the entries that is shared not only by link | ||
| * @param {object[]} entries | ||
| * @param {object} byDocId |
There was a problem hiding this comment.
nit: can't you be more specific than that? entries is an array of IoCozyFiles?
There was a problem hiding this comment.
I added the type from cozy-client to be more specific
Crash--
approved these changes
Dec 6, 2023
cballevre
force-pushed
the
feat/moving-only-shared-by-link
branch
from
86283a0 to
faa7e86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.