Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VO-420] feat: Migrate cozy-bar from v10 to v11 #2810

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

cballevre
Copy link
Contributor

@cballevre cballevre commented Jan 3, 2023

### 🔧 Tech
* Remove bar context

We are using the second version of <BarComponent /> now

Related PRs:

@cballevre cballevre requested a review from Crash-- January 3, 2023 13:35
@cballevre cballevre force-pushed the fix/remove-bar-context branch from 10dd010 to 23891b0 Compare May 26, 2023 09:10
@cballevre cballevre force-pushed the fix/remove-bar-context branch from 23891b0 to 66c8981 Compare November 3, 2023 16:01
@cballevre cballevre force-pushed the fix/remove-bar-context branch from 66c8981 to e38aee4 Compare November 29, 2023 17:17
@cballevre cballevre changed the title Fix: Remove bar context [VO-221] fix: Remove bar context Jan 15, 2024
@cballevre cballevre changed the title [VO-221] fix: Remove bar context [VO-221] feat: Migrate cozy-bar from v10 to v11 Jan 18, 2024
@cballevre cballevre force-pushed the fix/remove-bar-context branch from e38aee4 to cfbfaa7 Compare January 18, 2024 18:01
@cballevre cballevre force-pushed the fix/remove-bar-context branch from cfbfaa7 to 2f9e9c4 Compare January 26, 2024 16:16
@cballevre cballevre marked this pull request as ready for review January 26, 2024 16:18
@cballevre cballevre requested a review from zatteo as a code owner January 26, 2024 16:18
Copy link

bundlemon bot commented Jan 26, 2024

BundleMon

Files updated (6)
Status Path Size Limits
public/drive.(hash).js
1.52MB (+3.4KB +0.22%) 1.7MB
vendors/drive.(hash).js
1.72MB (+2.23KB +0.13%) 2MB
index.html
590B (+43B +7.86%) 1KB
intents/drive.(hash).js
104.5KB (+33B +0.03%) 190KB
app/drive.(hash).js
165.56KB (-395B -0.23%) 300KB
public/drive.(hash).min.css
70.57KB (-4.06KB -5.44%) 100KB
Unchanged files (12)
Status Path Size Limits
public/pdf.worker.entry.(hash).worker.js
343.61KB 345KB
services/dacc/drive.js
265.69KB 500KB
services/qualificationMigration/drive.js
259.96KB 500KB
public/cozy-client-js.js
158.97KB 160KB
app-drive.(hash).min.css
37.26KB 56KB
intents-drive.(hash).min.css
34.9KB 40KB
onlyOffice/slide.pptx
24.82KB 25KB
onlyOffice/text.docx
5.84KB 6KB
onlyOffice/spreadsheet.xlsx
5.01KB 6KB
manifest.webapp
1.9KB 2KB
intents/index.html
505B 1KB
manifest.json
184B 1KB

Total files change +1.27KB +0.03%

Groups updated (4)
Status Path Size Limits
vendors/**
1.72MB (+2.23KB +0.13%) -
intents/**
104.99KB (+34B +0.03%) -
app/**
165.56KB (-395B -0.23%) -
public/**
2.09MB (-671B -0.03%) -
Unchanged groups (3)
Status Path Size Limits
services/**
525.65KB -
onlyOffice/**
35.68KB -
img/**
3.41KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@cballevre cballevre force-pushed the fix/remove-bar-context branch from 2f9e9c4 to 7c0aedc Compare February 7, 2024 08:28
@cballevre cballevre changed the title [VO-221] feat: Migrate cozy-bar from v10 to v11 [VO-420] feat: Migrate cozy-bar from v10 to v11 Feb 16, 2024
cballevre and others added 6 commits March 6, 2024 10:53
feat: Improve bar integration
Before the cozy-bar v11, we can use hook from provider outer of the Bar because they didn't share the same react tree now we can simplifies things a bit
@cballevre cballevre force-pushed the fix/remove-bar-context branch from 9c9ef16 to 3354d24 Compare March 6, 2024 09:57
@cballevre cballevre merged commit 0011549 into master Mar 6, 2024
3 checks passed
@cballevre cballevre deleted the fix/remove-bar-context branch March 6, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants