support annotation #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JqRrt
force-pushed
the
feat_support_annotation
branch
from
8eb2017 to
43d8078
Compare
taoyifan89
reviewed
Jun 5, 2025
| span_type: Optional[str] = None, | ||
| tags: Optional[Dict[str, Any]] = None, | ||
| client: Optional[Client] = None, | ||
| process_inputs: Optional[Callable[[dict], Any]] = None, |
There was a problem hiding this comment.
这几个process方法，找个地方加些注释说明一下入参是什么样子的吧
examples/trace/annotation.py
Outdated
| pass | ||
|
|
||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
example感觉看不太明白，是不是找一些相对真实的case写一下？
sync、async看看有没有必要分多个文件容易看一些？
taoyifan89
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.