-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update bot api support knowledge #176
feat: Update bot api support knowledge #176
Conversation
WalkthroughThe pull request introduces a new Changes
Sequence DiagramsequenceDiagram
participant User
participant BotsClient
participant Bot
User->>BotsClient: create/update bot
User->>BotsClient: with BotKnowledge
BotsClient->>Bot: Configure knowledge settings
Bot-->>BotsClient: Bot with knowledge configuration
BotsClient-->>User: Configured bot
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cozepy/bots/__init__.py (1)
23-30
: Consider using an enum for search_strategy values.The search strategy values (0, 1, 20) would be better represented as an enum, similar to how
BotMode
is implemented. This would improve code maintainability and type safety.+class BotSearchStrategy(IntEnum): + SEMANTIC_SEARCH = 0 + HYBRID_SEARCH = 1 + FULL_TEXT_SEARCH = 20 + class BotKnowledge(CozeModel): dataset_ids: List[str] = [] auto_call: bool = True - search_strategy: int = 0 + search_strategy: BotSearchStrategy = BotSearchStrategy.SEMANTIC_SEARCH
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
cozepy/__init__.py
(2 hunks)cozepy/bots/__init__.py
(8 hunks)
🔇 Additional comments (4)
cozepy/bots/__init__.py (3)
86-87
: LGTM!The knowledge attribute is well-documented and properly integrated into the Bot class with correct type hints.
169-169
: LGTM!The knowledge parameter is well-integrated into the update method with comprehensive documentation and consistent implementation.
Also applies to: 188-188, 199-199
324-324
: LGTM!The knowledge parameter implementation in the async client perfectly mirrors the sync client implementation.
Also applies to: 343-343, 354-354
cozepy/__init__.py (1)
25-25
: LGTM!The BotKnowledge class is properly exposed in the module's public interface.
Also applies to: 183-183
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 90.01% 90.02%
=======================================
Files 65 65
Lines 5840 5845 +5
=======================================
+ Hits 5257 5262 +5
Misses 583 583
|
#167
Summary by CodeRabbit
New Features
BotKnowledge
configuration option for bots.Improvements