-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Publish release/20250303-4e87f3 #124
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request removes several JSON files that previously documented minor changes in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant API
participant WorkflowExecutor
participant HistoryTracker
User->>API: Request async workflow execution
API->>WorkflowExecutor: Initiate workflow
WorkflowExecutor->>HistoryTracker: Record start
WorkflowExecutor-->>API: Workflow complete
API->>HistoryTracker: Log completion
API-->>User: Send acknowledgment
sequenceDiagram
participant User
participant API
participant VideoManager
User->>API: Start screen sharing session
API->>VideoManager: Activate screen sharing & persist video device
VideoManager-->>API: Confirm activation
API-->>User: Screen sharing active
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/realtime-api/CHANGELOG.md (1)
5-10
: New Features List – Consistency CheckThe new features listed (screen sharing support, test code, and unit test) effectively communicate the updates. Consider standardizing capitalization (e.g. “add test code” vs. “Add test code”) for improved consistency.
packages/realtime-api/CHANGELOG.json (1)
4-21
: New Version JSON Entry VerificationThe JSON entry for version “1.1.0” is structured correctly with the proper ISO date and comment details. Please consider reviewing the text casing in the comments to ensure it aligns with your team's conventions (e.g. “add...” vs. “Add...”).
packages/coze-js/CHANGELOG.md (2)
5-15
: Comprehensive New Features DocumentationThe list under “### New Features” is extensive and informative. To enhance clarity, consider standardizing the capitalization and phrasing across bullet points (for example, “Add playback timing and state management” versus “update README.md” versus “Update readme”).
16-19
: Bug Fixes Section QueryThe “### Bug Fixes” section lists “add unit test.” Since a similar entry appears in the New Features section, please verify if this duplication is intentional or if the categorization needs adjustment.
packages/coze-js/CHANGELOG.json (1)
4-41
: New Version JSON Entry – Duplication CheckThe entry for version “1.1.0” is detailed and correctly structured. However, the comment “add unit test” appears in both the “minor” (line 17) and “patch” (line 37) sections. Please verify whether this duplication is intended or if one instance should be removed or reclassified.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (23)
common/changes/@coze/api/feat-api_2025-02-27-11-10.json
(0 hunks)common/changes/@coze/api/feat-api_2025-02-27-12-38.json
(0 hunks)common/changes/@coze/api/feat-api_2025-02-28-03-27.json
(0 hunks)common/changes/@coze/api/feat-share_screen_2025-02-21-09-29.json
(0 hunks)common/changes/@coze/api/feat-share_screen_2025-02-24-06-38.json
(0 hunks)common/changes/@coze/api/feat-share_screen_2025-02-27-13-12.json
(0 hunks)common/changes/@coze/api/feat-websocket-api_2025-02-17-07-31.json
(0 hunks)common/changes/@coze/api/feat-websocket-api_2025-02-17-08-59.json
(0 hunks)common/changes/@coze/api/feat-websocket-api_2025-02-17-09-05.json
(0 hunks)common/changes/@coze/api/feat-websocket-api_2025-02-20-02-54.json
(0 hunks)common/changes/@coze/api/feat-websocket-api_2025-02-20-03-16.json
(0 hunks)common/changes/@coze/api/feat-websocket-api_2025-02-20-05-13.json
(0 hunks)common/changes/@coze/api/fix-workflow_2025-02-24-12-00.json
(0 hunks)common/changes/@coze/realtime-api/feat-share_screen_2025-02-21-09-29.json
(0 hunks)common/changes/@coze/realtime-api/feat-share_screen_2025-02-24-06-38.json
(0 hunks)common/changes/@coze/realtime-api/feat-share_screen_2025-02-27-12-50.json
(0 hunks)common/changes/@coze/realtime-api/feat-share_screen_2025-02-27-13-27.json
(0 hunks)packages/coze-js/CHANGELOG.json
(1 hunks)packages/coze-js/CHANGELOG.md
(1 hunks)packages/coze-js/package.json
(1 hunks)packages/realtime-api/CHANGELOG.json
(1 hunks)packages/realtime-api/CHANGELOG.md
(1 hunks)packages/realtime-api/package.json
(1 hunks)
💤 Files with no reviewable changes (17)
- common/changes/@coze/api/feat-websocket-api_2025-02-17-07-31.json
- common/changes/@coze/api/feat-share_screen_2025-02-21-09-29.json
- common/changes/@coze/api/feat-websocket-api_2025-02-20-02-54.json
- common/changes/@coze/api/fix-workflow_2025-02-24-12-00.json
- common/changes/@coze/api/feat-websocket-api_2025-02-17-09-05.json
- common/changes/@coze/api/feat-websocket-api_2025-02-20-05-13.json
- common/changes/@coze/api/feat-share_screen_2025-02-27-13-12.json
- common/changes/@coze/api/feat-websocket-api_2025-02-20-03-16.json
- common/changes/@coze/api/feat-share_screen_2025-02-24-06-38.json
- common/changes/@coze/realtime-api/feat-share_screen_2025-02-27-13-27.json
- common/changes/@coze/realtime-api/feat-share_screen_2025-02-21-09-29.json
- common/changes/@coze/api/feat-api_2025-02-27-11-10.json
- common/changes/@coze/api/feat-api_2025-02-27-12-38.json
- common/changes/@coze/realtime-api/feat-share_screen_2025-02-27-12-50.json
- common/changes/@coze/realtime-api/feat-share_screen_2025-02-24-06-38.json
- common/changes/@coze/api/feat-websocket-api_2025-02-17-08-59.json
- common/changes/@coze/api/feat-api_2025-02-28-03-27.json
✅ Files skipped from review due to trivial changes (2)
- packages/realtime-api/package.json
- packages/coze-js/package.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Node.js v20 (ubuntu-latest)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
packages/realtime-api/CHANGELOG.md (1)
3-4
: New Version Header AddedThe header “## 1.1.0 - 2025-03-03” is clearly formatted and placed at the top of the new version entry.
packages/coze-js/CHANGELOG.md (1)
3-4
: New Version Header VerificationThe header “## 1.1.0 - 2025-03-03” is correctly added and visually aligns with the project’s changelog style.
Summary by CodeRabbit
New Features
Documentation
Chores