-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protocol fee #333
Merged
Merged
Add protocol fee #333
Changes from 33 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
00f19da
add new column simulation_block to settlement_scores table
fhenneke ef1bb80
rename test db script
fhenneke 41aba0b
add test for order quotes
fhenneke cc6dfc5
forgot to add actual test
fhenneke fe9e5aa
add protocol fee data to test database
fhenneke 6cea067
update database
fhenneke 274c804
add protocol fee query
fhenneke 93d209e
fix typo
fhenneke 0db2785
update database and query
fhenneke 41bf651
update query and database
fhenneke c64cccf
revert changes to batch rewards database
fhenneke 49e887d
simplify order quotes test database
fhenneke 907f46d
move batch rewards test db setup
fhenneke e3ec33a
black fix
fhenneke 35b96ad
remove old test database file
fhenneke da2c4c4
fix black issue
fhenneke 6a09ceb
Merge branch 'update_tests' into protocol_fee
fhenneke 397fe66
Merge branch 'main' into protocol_fee
fhenneke f4438cd
modified query
fhenneke 1aa5a77
add protocol fees to batch rewards query
fhenneke 604b4a4
address review comments
fhenneke 34462be
add protocol fees to transfers
fhenneke 579b55c
black fix
fhenneke ea970bb
more black fixes
fhenneke 4ffea87
small fix to query
fhenneke b76b3ed
remove unused files
fhenneke 9419122
Revert "add protocol fees to transfers"
fhenneke 8afce0f
rename tables and compute network fee
fhenneke e6d0b95
remove unused protocol fee query
fhenneke 307401e
add protocol fee transfer to special safe
fhenneke 9f26901
correct volume cap for protocol fee
fhenneke 0a8d0ee
fix test
fhenneke a0bbdcd
fix error in volume based fee
fhenneke b726a52
add protocol fee info to logs
fhenneke 85e07a4
cast protocol fee to int in transfer
fhenneke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe i had cast the right-hand side to
int
. Will need to double-check if this is still needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the cast. (It is a bit worrying that we do not have a test to check for that.)