[EASY] Improve settlement tx cancellation logging #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
changed the title
MartinquaXD
approved these changes
Dec 17, 2024
squadgazzz
force-pushed
the
tx-cancellation-logs
branch
from
c13dc0a to
a263efd
Compare
sunce86
approved these changes
Dec 17, 2024
| tracing::info!( | ||
| ?hash, | ||
| settle_tx_hash = ?hash, |
There was a problem hiding this comment.
We are now skipping the log if self.cancel returns error. Hope this is intended by this PR?
There was a problem hiding this comment.
Yes, we do. In case of cancellation fails, we have an enriched context error to understand which path that was.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ATM, it is not possible to understand whether a settlement cancellation tx succeeded. This PR adds logs with the cancellation tx hash, so it will be possible to check the transaction on chain later. Also, additional context is added when working with the cancellation tx submission since, currently, it is impossible to distinguish between the actual settlement tx submission error.