Driver /quote response with JIT orders
#3033
Conversation
squadgazzz
force-pushed
the
3027/driver-quote-response-jit-orders
branch
from
beba8c2 to
996f487
Compare
squadgazzz
changed the title
squadgazzz
changed the title
/quote response with JIT orders
The plan was to prepare an e2e test once autopilot and orderbook are prepared to handle the updated quote response. Does it make sense to have an e2e test with the current PR state? |
| type: string | ||
| signingScheme: | ||
| type: string | ||
| enum: ["eip712", "ethsign", "presign", "eip1271"] |
There was a problem hiding this comment.
Why all these fields? Where are they used and by who?
There was a problem hiding this comment.
We need all the signed order data to verify quotes via simulations. Will happen in a follow up PR.
There was a problem hiding this comment.
I assume fee_amount is forced to be 0 with the decision of not putting it in the list. Although, theoretically solvers can settle a JIT order with fee_amount != 0 leading to a different signature.
But still, probably not worth handling...
There was a problem hiding this comment.
Yeah. Let's not re-introduce fee_amount handling if we can avoid it. Hopefully fee_amount goes away entirely in the new contract anyway. 🤞
Not yet. I'd say we can leave this PR unmerged until then since it's pretty straight forward. Once all the pieces are in place they can be merged together. WDYT? |
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
|
Will be reimplemented in scope of the #3082 |
Description
Changes
driver -> autopilot/orderbook/quotereponse to pass a list of pre-interactions and a list of JIT ordersHow to test
New driver tests(I can't express more how I want the driver's test framework to become more friendly).
Fixes #3027