Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use surplus token for total fee calculation (#2956)
# Description `fee_in_ether` is practically only used to store result into `settlement_observations.fee` field, which is used by solver team. We calculate the total fee in surplus token, as a first step always. Now, instead of using uniform clearing prices to convert that fee to sell token, and then into Ether using external prices, we go directly from surplus token -> Ether: before: `surplus token -> sell token -> Ether` after: `surplus token -> Ether` This is just a small step of moving all fees to be expressed over surplus token and remove conversions to sell token. @fhenneke please would like your approval first since you work with this result. ## How to test Existing tests.
- Loading branch information