This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bram-vdberg
commented
Nov 14, 2024
- Update SQLAlchemy version from <2.0 to >2.0&<3.0
- Update setup.py to install SQL files
This PR cleans up some leftover references to participation rewards
This PR adds a setup.py file so that the dune-sync repo can be installed with pip using `pip install git+https://github.com/cowprotocol/dune-sync.git@<branch-name>`. This can be tested with: `pip install git+https://github.com/cowprotocol/dune-sync.git@setup_pip`.
This PR updates the sqlalchemy version of the dune-sync repo to <3.0. This is needed for compatibility with Prefect. It also updates the setup.py to include the .sql files.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: pypi/[email protected] |
Rebasing the dev branch agains main accidentally introduced formatting changes to the setup.py that causes the tests to fail. This PR fixes this.
The tests failed the first time due to a timeout error. Re-running the tests seems to have fixed it. |
harisang
reviewed
Nov 15, 2024
harisang
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added small comment
Co-authored-by: Haris Angelidakis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.