Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Commit

Permalink
Merge pull request #85 from cowprotocol/fix_dataframe_concatentation_…
Browse files Browse the repository at this point in the history
…warning

Fix dataframe warning
  • Loading branch information
harisang authored Mar 5, 2024
2 parents ee866b9 + ff28366 commit abfc588
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions src/fetch/orderbook.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,13 @@ def get_order_rewards(cls, block_range: BlockRange) -> DataFrame:

# Solvers do not appear in both environments!
assert set(prod.solver).isdisjoint(set(barn.solver)), "solver overlap!"
return pd.concat([prod, barn])
if not prod.empty and not barn.empty:
return pd.concat([prod, barn])
if not prod.empty:
return prod.copy()
if not barn.empty:
return barn.copy()
return pd.DataFrame()

@classmethod
def get_batch_rewards(cls, block_range: BlockRange) -> DataFrame:
Expand Down Expand Up @@ -116,4 +122,10 @@ def get_batch_rewards(cls, block_range: BlockRange) -> DataFrame:

# Solvers do not appear in both environments!
assert set(prod.solver).isdisjoint(set(barn.solver)), "solver overlap!"
return pd.concat([prod, barn])
if not prod.empty and not barn.empty:
return pd.concat([prod, barn])
if not prod.empty:
return prod.copy()
if not barn.empty:
return barn.copy()
return pd.DataFrame()

0 comments on commit abfc588

Please sign in to comment.