Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Commit

Permalink
Update Dependency & Remove "unused ignore" (#46)
Browse files Browse the repository at this point in the history
* it was actually an unused ignore -- pandas must have updated
  • Loading branch information
bh2smith authored Jun 9, 2023
1 parent 728ea78 commit a004674
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
2 changes: 2 additions & 0 deletions mypy.ini
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
[mypy]

[mypy-src.sync]
implicit_reexport = True
3 changes: 2 additions & 1 deletion requirements/dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
pandas-stubs>=1.5.1.221024
boto3-stubs>=1.26.12
black>=22.6.0
mypy>=0.982
mypy==1.3.0
mypy-extensions==1.0.0
pylint>=2.14.4
pytest>=7.1.2
sqlalchemy-stubs>=0.4
2 changes: 1 addition & 1 deletion src/fetch/orderbook.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def _read_query_for_env(
# It seems there is a bug in mypy on the dtype field (with error [arg-type]).
# They expect types that should align with what we pass.
# More context at: https://github.com/cowprotocol/dune-sync/issues/24
return pd.read_sql_query(query, con=cls._pg_engine(env), dtype=data_types) # type: ignore
return pd.read_sql_query(query, con=cls._pg_engine(env), dtype=data_types)

@classmethod
def _query_both_dbs(
Expand Down
2 changes: 1 addition & 1 deletion src/fetch/postgres.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def __init__(self, db_url: str):
def _read_query(
self, query: str, data_types: Optional[dict[str, str]] = None
) -> DataFrame:
return pd.read_sql_query(query, con=self.engine, dtype=data_types) # type: ignore
return pd.read_sql_query(query, con=self.engine, dtype=data_types)

def get_latest_block(self) -> int:
"""
Expand Down

0 comments on commit a004674

Please sign in to comment.