Fix CoW AMM CoW surplus query #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old query was broken due to wrong handling of 80/20-pools. The updated query uses surplus as defined in the auction instead of relying on computing non-linear surplus using reserves.
fleupold
approved these changes
Nov 5, 2024
| where trades.trader in (select address from query_3959044 where blockchain = 'gnosis') | ||
| ), | ||
|
|
||
| cow_surplus_per_batch as ( |
There was a problem hiding this comment.
Why are we not including arbitrum AMMs here? I think they also qualify for the bounty.
There was a problem hiding this comment.
It is easy to add that if it qualifies. Let me double check with @harisang.
I mostly tried to stick to what the previous query did. Note, that the query previously used was not the same as the one under version control. It explicitly used tables for ethereum and gnosis, but not arbitrum.
There was a problem hiding this comment.
I added a table for arbitrum. Interestingly, there is no difference in total surplus. I briefly checked the intermediate tables and they seem to work. So I think it is fine to merge this.
the where clause used a column which was not present in the debug table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the query for computing CoW surplus of CoW AMMs for the onboing bounty.
The old query was broken due to 80/20-pools since it used a formula for surplus which worked directly with reserves and product invariant ("non-linear surplus"). The resulted in the potential of negative surplus, messing up bounty rewards:
The new query uses surplus as defined in the competition ("linear suplus"). This generalizes to all kinds of CoW AMMs. It also reduces the dependency on a large table which indexes reserves of all CoW AMMs. The results with the updated query (test query) change to this:
One change in behavior is that we now do not reward solvers in cases where the limit price set by the solver does not lie on the curve. This is, however, in line with how we treat rewards in general and should not have a major impact.