Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bonding pools #58

Closed
wants to merge 1 commit into from
Closed

Update bonding pools #58

wants to merge 1 commit into from

Conversation

bram-vdberg
Copy link
Contributor

@bram-vdberg bram-vdberg commented Oct 25, 2024

This PR updates the hardcoded bonding pools to include Rizzolver and Furucombo/Portus. The pools can be found on the CMS under solver-bonding pools

@bram-vdberg bram-vdberg requested a review from harisang October 25, 2024 14:05
@harisang
Copy link
Contributor

Note these are reduced subpools within the CoW DAO bonding pool, and so far we haven't added any other subpool that has been created in this query. The main query used for the service fee is this: https://dune.com/queries/4017925
and it has a colocated_solvers hardcoded table. So I don't really agree with this PR.

@bram-vdberg
Copy link
Contributor Author

Note these are reduced subpools within the CoW DAO bonding pool, and so far we haven't added any other subpool that has been created in this query. The main query used for the service fee is this: https://dune.com/queries/4017925 and it has a colocated_solvers hardcoded table. So I don't really agree with this PR.

Sorry, looks like I updated the wrong query. I'll redo the PR to update cowprotocol/accounting/rewards/mainnet/service_fee_query_4017925.sql.

@fleupold
Copy link
Contributor

Oh my bad, I should have checked more carefully.

Sorry, looks like I updated the wrong query.

Can you document the process in Notion please so that it's easy to follow for future solvers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants