[CoW AMM] 10k growth for HODL strategy #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
force-pushed
the
cowamm/hodl
branch
from
356b0e1 to
171e06b
Compare
harisang
reviewed
Oct 2, 2024
| select | ||
| ds.day, | ||
| token_a_start * p1.price_close + token_b_start * p2.price_close as current_value_of_investment | ||
| from starting_balance, date_series as ds |
There was a problem hiding this comment.
I admit i had never seen this comma notation, and i would probably prefer a more explicit join but i tested it and it works so i am fine with it
There was a problem hiding this comment.
replaced with cross join (which is semantically equivalent)
harisang
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a super meaningful but fun and simple metric to compute, this query plots the 10k growth graph of "not LPing" (ie. holding the two assets). The difference is usually referred to as "impermanent loss".
Test Plan
https://dune.com/queries/4059180/6834667