Skip to content

Native token liquidity clarification #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

squadgazzz
Copy link
Contributor

@squadgazzz squadgazzz commented Mar 27, 2025

Description

Adds a tiny clarification for the native token liquidity.

Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 28, 2025 8:43am

Copy link

github-actions bot commented Mar 27, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@squadgazzz
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@squadgazzz squadgazzz marked this pull request as ready for review March 27, 2025 17:44
@squadgazzz squadgazzz requested a review from a team as a code owner March 27, 2025 17:44
github-actions bot added a commit that referenced this pull request Mar 27, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@@ -10,6 +10,8 @@ For a token to be considered tradeable on CoW Protocol, it **MUST**:
- Have a valid price provided by a _price estimator_ for an order worth **0.1 ETH** of the token (For Ethereum mainnet and Arbitrum One)
- Have a valid price provided by a _price estimator_ for an order worth **1 xDAI** of the token (For Gnosis)
- Not be on the bad token list
- Have sufficient liquidity in a pool paired with the chain's wrapped native token (e.g., WETH, WXDAI), such that a buy order worth **1 whole unit** of the native token can be placed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already mentioned two lines above? There doesn't need to be a direct pool, just a native price estimator. Maybe we can advise that the best way to guarantee this is by creating a direct pool with sufficient liquidity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how i missed that. Thanks, updated the PR.

Copy link
Contributor

@cowmarketing cowmarketing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add amounts so that it reads "with the required minimum amounts".?

@@ -9,6 +9,7 @@ For a token to be considered tradeable on CoW Protocol, it **MUST**:
- Be [`ERC-20`](https://eips.ethereum.org/EIPS/eip-20) compliant
- Have a valid price provided by a _price estimator_ for an order worth **0.1 ETH** of the token (For Ethereum mainnet and Arbitrum One)
- Have a valid price provided by a _price estimator_ for an order worth **1 xDAI** of the token (For Gnosis)
- The most reliable way to meet the above requirements is to bootstrap a direct liquidity pool (e.g., Uni v2) with the required minimum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make it explicit that you mean a WETH <> TOKEN pool on uni v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants