-
Notifications
You must be signed in to change notification settings - Fork 16
Native token liquidity clarification #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@@ -10,6 +10,8 @@ For a token to be considered tradeable on CoW Protocol, it **MUST**: | |||
- Have a valid price provided by a _price estimator_ for an order worth **0.1 ETH** of the token (For Ethereum mainnet and Arbitrum One) | |||
- Have a valid price provided by a _price estimator_ for an order worth **1 xDAI** of the token (For Gnosis) | |||
- Not be on the bad token list | |||
- Have sufficient liquidity in a pool paired with the chain's wrapped native token (e.g., WETH, WXDAI), such that a buy order worth **1 whole unit** of the native token can be placed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this already mentioned two lines above? There doesn't need to be a direct pool, just a native price estimator. Maybe we can advise that the best way to guarantee this is by creating a direct pool with sufficient liquidity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea how i missed that. Thanks, updated the PR.
1c0d6fd
to
d329f2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add amounts so that it reads "with the required minimum amounts".?
@@ -9,6 +9,7 @@ For a token to be considered tradeable on CoW Protocol, it **MUST**: | |||
- Be [`ERC-20`](https://eips.ethereum.org/EIPS/eip-20) compliant | |||
- Have a valid price provided by a _price estimator_ for an order worth **0.1 ETH** of the token (For Ethereum mainnet and Arbitrum One) | |||
- Have a valid price provided by a _price estimator_ for an order worth **1 xDAI** of the token (For Gnosis) | |||
- The most reliable way to meet the above requirements is to bootstrap a direct liquidity pool (e.g., Uni v2) with the required minimum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make it explicit that you mean a WETH <> TOKEN
pool on uni v2.
Description
Adds a tiny clarification for the native token liquidity.