Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate E2E buyEth tests to Foundry #212

Conversation

meetmangukiya
Copy link

@meetmangukiya meetmangukiya commented Sep 6, 2024

Description

Migrate buyEth e2e test to foundry. Depends on #215

Test Plan

CI

Related Issues

Closes #135

@meetmangukiya meetmangukiya requested a review from a team as a code owner September 6, 2024 12:54
Copy link
Contributor

github-actions bot commented Sep 6, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@meetmangukiya
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@meetmangukiya
Copy link
Author

recheck

Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this please be rebased on #215 so that CI/CD can pass?

test/e2e/BuyEth.t.sol Outdated Show resolved Hide resolved
test/e2e/BuyEth.t.sol Show resolved Hide resolved
@meetmangukiya meetmangukiya requested a review from mfw78 September 26, 2024 06:13
@mfw78 mfw78 changed the base branch from main to e2e-migration October 7, 2024 10:58
@mfw78 mfw78 force-pushed the e2e-migrate-buy-eth branch from 5d22ca0 to ecae951 Compare October 7, 2024 11:01
@mfw78 mfw78 changed the base branch from e2e-migration to mfw78-patch-1 October 7, 2024 12:12
@mfw78 mfw78 force-pushed the e2e-migrate-buy-eth branch from ecae951 to 8022cd9 Compare October 7, 2024 12:23
@mfw78 mfw78 deleted the branch cowprotocol:mfw78-patch-1 October 7, 2024 12:49
@mfw78 mfw78 closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests(e2e): buyEth
2 participants