chore: remove unused functions and move single-use function #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedgiac
force-pushed
the
remove-unused-test-functions
branch
from
6ba90a9 to
db2a49c
Compare
mfw78
approved these changes
Sep 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wanted to see how many of the helper TS functions/contracts were still needed.
Notably, I removed
sign.test.tsbecause it just tests a specific feature of the Typescript library and has no relevance to the contract code.I also wanted to remove the Chi token, but this required simplifying the bench and already on current main we see that
yarn bench:tracedoesn't work anymore (probably because experimental tracing stopped working). I didn't want to possible aggravate the issue with this PR so I left everything as it was to be solved at a later point.I didn't remove
decoding.test.tsso that in the future we double check that our Solidity test libraries have the same tests.Test Plan
CI.
Related Issues
Closes #128.