Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test contracts to test folder #162

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Conversation

fedgiac
Copy link
Contributor

@fedgiac fedgiac commented Jun 7, 2024

Description

Moves files from src/contracts/test to test/src (from which they will be further pulled out until no contract is left there.
This is to avoid triggering the mandatory two reviews check on PRs that move these files to the test folder.

This PR will be merged with a single review.

Test Plan

Code compiles. Number of changes is constant before fmt.

@fedgiac fedgiac requested a review from a team as a code owner June 7, 2024 12:55
@fedgiac fedgiac force-pushed the test-contracts-to-test-folder branch from da48999 to 23be509 Compare June 7, 2024 12:57
Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staged review: reviewed movement of files

Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staged review: reviewed lint

@mfw78 mfw78 added the E:5.2 Contracts migrations See https://github.com/cowprotocol/pm/issues/32 for details label Jun 7, 2024
@fedgiac fedgiac merged commit a10f407 into main Jun 7, 2024
8 of 9 checks passed
@fedgiac fedgiac deleted the test-contracts-to-test-folder branch June 7, 2024 13:48
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E:5.2 Contracts migrations See https://github.com/cowprotocol/pm/issues/32 for details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants