Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check formatting on CI #161

Merged
merged 3 commits into from
Jun 7, 2024
Merged

chore: check formatting on CI #161

merged 3 commits into from
Jun 7, 2024

Conversation

fedgiac
Copy link
Contributor

@fedgiac fedgiac commented Jun 7, 2024

Description

New GitHub action that enforces forge fmt formatting for files outside of src/.
No changes to source files were needed.

Test Plan

CI. Try to break formatting locally and see that forge fmt --check catches that as long as it's not in src/.

@fedgiac fedgiac requested a review from a team as a code owner June 7, 2024 09:31
Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@mfw78 mfw78 assigned mfw78 and fedgiac and unassigned mfw78 Jun 7, 2024
@mfw78 mfw78 added the E:5.2 Contracts migrations See https://github.com/cowprotocol/pm/issues/32 for details label Jun 7, 2024
@fedgiac fedgiac merged commit b4d64fd into main Jun 7, 2024
9 checks passed
@fedgiac fedgiac deleted the format-tests branch June 7, 2024 11:21
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E:5.2 Contracts migrations See https://github.com/cowprotocol/pm/issues/32 for details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants