Merge pull request #74 from covermymeds/set_mssql_pass_as_env_var

Security improvement
covermymeds · Jun 25, 2020 · 5d59e43 · 5d59e43
2 parents fbf8e3e + 79c3c6f
commit 5d59e43
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 2020-06-25 Release 1.5.9
+### Summary
+Security Fix
+
+### Changes
+  - Change mssql dbtype to use environment variable instead of passing password on cli
+
 ## 2020-04-30 Release 1.5.8
 ### Summary
 Bug fix

diff --git a/dbdeployer_release b/dbdeployer_release
@@ -1 +1 @@
-version=1.5.8
+version=1.5.9
diff --git a/dbtype/mssql/set_password_flags.sh b/dbtype/mssql/set_password_flags.sh
@@ -1,4 +1,5 @@
 function set_password_flags() {
-  password_flag="-P${password}"
+  password_flag=""
+  export SQLCMDPASSWORD="${password}"
   return 0
 }