Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyberark refactor #96

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Cyberark refactor #96

wants to merge 6 commits into from

Conversation

joseph-klein-cmm
Copy link

@joseph-klein-cmm joseph-klein-cmm commented Jan 15, 2025

Summary

Adds the ability for secrets to be pulled from CyberArk, as well as AKV.

This includes a good bit of refactoring to avoid having to a) litter the code with type checks, and b) try to hijack the keyvault-based Secret object for storing CyberArk secrets. At a high level, the refactoring:

  1. Abstracts the client code to allow an additional implementation for CyberArk
  2. Moves the resource retrieval functions (GetSecret, GetKey, etc) to methods of the concrete Client objects.
  3. Create a new Secret resource type that can be used for both CyberArk and AKV secrets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant