Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest audited contracts #41

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Merge latest audited contracts #41

merged 5 commits into from
Jun 4, 2024

Conversation

rogarcia
Copy link
Collaborator

@rogarcia rogarcia commented May 15, 2024

I merged the audited contracts (from the cqt-staking repo main branch) and committed hardhat tooling updates (current nodejs v18.20.2 LTS + Openzepplin Defender 2.0 dependencies).
Tests removed for now (we need to copy updated ones from the private repo (cqt-staking) - but need to sanitized/tested before that).
This ensures contract upgrade proposals work with Openzepplin Defender 2.0.

@rogarcia rogarcia marked this pull request as ready for review May 28, 2024 07:56
@rogarcia rogarcia requested a review from noslav May 28, 2024 07:58
Copy link
Member

@noslav noslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving a merge on the basis of -

  1. Two separate audits for staking contract migration to Ethereum with proof-chain on Moonbeam and bridge-agent (StakingManager) operation, those can be found here -
    a. Quantstamp - https://github.com/covalenthq/ewm-contracts/blob/main/audits/operational-staking/v3/quantstamp.pdf
    b. Sherlock - https://github.com/covalenthq/ewm-contracts/blob/main/audits/operational-staking/v3/sherlock.pdf

  2. Zero diff on deployed in production Ethereum mainnet contracts BSP-Staking , BRP-Staking and Moonbeam mainnet contracts BSP-ProofChain BRP-ProofChain for contract code added in this PR https://github.com/covalenthq/ewm-contracts/tree/main/contracts -
    a. contracts/BlockResultProofChain.sol
    b. contracts/BlockSpecimenProofChain.sol
    c. contracts/OperationalStaking.sol

  3. Previously added tests have been removed on approval to keep CI runs simple without any tests (they are mentioned in the reports however), deleted en masse -
    a. test/proof-chain/unit-tests/**
    b. test/operational-staking/unit-tests/**

  4. Updated ABIs and audit reports
    a. https://github.com/covalenthq/ewm-contracts/tree/main/audits/operational-staking/v3
    b. https://github.com/covalenthq/ewm-contracts/tree/main/generated-abis

@noslav noslav merged commit 357752c into main Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants