Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete EIP-4844 blob export support (Ethereum Migration v1.5) #198

Merged
merged 12 commits into from
Apr 24, 2024
Merged

Conversation

noslav
Copy link
Member

@noslav noslav commented Mar 28, 2024

  • Creates a channel for chain sync miner to push blob data
  • Enable channel to accept blob based on --replica.blob flag provided as replication target
  • Pushes BlobTxSidecar data into the channel with the corresponding block number
  • Restructures replica segments to consume blob data and export block-specimens and block-results with blobs
  • Adds support for additional type 3 tx fields like BlobFeeCap, BlobHashes and BlobGas
  • Passes tests and doesn't block validator chain sync

@noslav
Copy link
Member Author

noslav commented Mar 28, 2024

Screenshot 2024-03-28 at 15 34 01
Lifecycle of ingesting and exporting blobs

@noslav noslav force-pushed the develop branch 2 times, most recently from af0fe96 to 68154e3 Compare April 17, 2024 23:26
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0.84034% with 118 lines in your changes are missing coverage. Please review.

Project coverage is 57.23%. Comparing base (82b1d1f) to head (b720ac5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   57.34%   57.23%   -0.11%     
==========================================
  Files         600      600              
  Lines       80100    80157      +57     
==========================================
- Hits        45932    45878      -54     
- Misses      30285    30404     +119     
+ Partials     3883     3875       -8     
Files Coverage Δ
cmd/geth/chaincmd.go 10.10% <ø> (ø)
cmd/geth/main.go 44.02% <ø> (ø)
params/version.go 39.13% <ø> (ø)
eth/backend.go 0.00% <0.00%> (ø)
cmd/utils/flags.go 1.11% <0.00%> (-0.01%) ⬇️
core/blockchain.go 63.93% <14.28%> (-0.38%) ⬇️
miner/worker.go 66.51% <0.00%> (+0.72%) ⬆️
core/types/block_export.go 0.00% <0.00%> (ø)
core/block_replica.go 0.00% <0.00%> (-32.76%) ⬇️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b1d1f...b720ac5. Read the comment docs.

@noslav noslav mentioned this pull request Apr 18, 2024
@noslav noslav changed the title Full EIP-4844 (blob) support for block specimens Conditional complete EIP-4844 blob capture and export support for bsp-geth Apr 18, 2024
@noslav
Copy link
Member Author

noslav commented Apr 18, 2024

Support included forbsp-agent with covalenthq/bsp-agent#244

@noslav noslav changed the title Conditional complete EIP-4844 blob capture and export support for bsp-geth Complete EIP-4844 blob export support (Ethereum Migration v1.5) Apr 24, 2024
Signed-off-by: Pranay Valson <[email protected]>
@noslav noslav merged commit fd1af89 into main Apr 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant