Fix bug preventing DataTemplates.readRecord from processing generated templates #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eboto
force-pushed
the
data-templates-NoSuchMethodException
branch
from
eda6ee7
to
a501a35
Compare
eboto
pushed a commit
to eboto/courier
that referenced
this pull request
Jan 16, 2018
…lates (coursera#71) Also: - Enable scala-runtime test cases
eboto
changed the title
…lates (coursera#72) Also: - Enable scala-runtime test cases
eboto
force-pushed
the
data-templates-NoSuchMethodException
branch
from
a501a35
to
9e5d82d
Compare
|
Looks like CI did not even run on the build. Any idea why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test-cases to reproduce the bug described in #72, and fixes that bug.
Also enables the test-cases in the
scala-runtimebuild unit. I don't think they were ever running!