Specify credential resources #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt-Woz
reviewed
Feb 5, 2025
src/cli/credentials_create.rs
Outdated
| let bucket = call.get_flag(engine_state, stack, "bucket")?; | ||
| let scopes_flag: Option<Value> = call.get_flag(engine_state, stack, "scopes")?; | ||
|
|
||
| let scopes = if let Some(scopes) = scopes_flag { |
There was a problem hiding this comment.
NIT: I think if let Some() feels a bit redundant here given we're matching on scopes later anyway. Could we just match on scopes_flag instead? Maybe we could use guards for the bucket check. What do you think?
There was a problem hiding this comment.
Good point, that's a lot neater. And thanks for the link about 'guards' wasn't aware of them :)
There was a problem hiding this comment.
No problem, we could also flatten it by matching directly on e.g. Some(Value::String { val, .. }), but I think this is good too
Westwooo
force-pushed
the
specify_credential_resources
branch
from
dfb9509 to
2987825
Compare
Matt-Woz
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #576